feat: support remote search by handle #2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🚨 Potential breaking changes
👕 size: XL
type: feature ✨
labels
MohamadJaara
requested review from
saleniuk,
vitorhugods,
yamilmedina,
a team,
typfel and
ohassine
and removed request for
saleniuk,
vitorhugods and
a team
Datadog ReportBranch report: ✅ 0 Failed, 2659 Passed, 128 Skipped, 9m 21s Wall Time |
saleniuk
approved these changes
Jan 31, 2024
logic/src/commonTest/kotlin/com/wire/kalium/logic/feature/search/SearchByHandleUseCaseTest.kt
Outdated
Show resolved
Hide resolved
logic/src/commonTest/kotlin/com/wire/kalium/logic/util/arrangement/dao/SearchDAOArrangement.kt
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #2435 +/- ##
====================================================
Coverage ? 58.34%
Complexity ? 21
====================================================
Files ? 1170
Lines ? 45431
Branches ? 4281
====================================================
Hits ? 26508
Misses ? 17004
Partials ? 1919 Continue to review full report in Codecov by Sentry.
|
vitorhugods
approved these changes
Feb 7, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
* feat: support remote search by handle * detekt * address PR comments
8 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
* feat: support remote search by handle * detekt * address PR comments Co-authored-by: Mohamad Jaara <[email protected]>
augustocdias
pushed a commit
that referenced
this pull request
Feb 13, 2024
* feat: support remote search by handle * detekt * address PR comments Co-authored-by: Mohamad Jaara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
support search by handle in the new remote search first approach
Solutions
add a new use case to do searhc by handle
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.